Remove v1 pools from LpSugar #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
This is good, but we'll have to remove the old v1 interface definitions, see the Aero fork for more context:
aerodrome-finance@02a9f33#diff-638bd86befbbe9f223dd728ed1b93f11689693558456f317ddd73761f60b77f5L102
contracts/LpSugar.vy
Outdated
| @@ -311,24 +311,20 @@ def forSwaps(_limit: uint256, _offset: uint256) -> DynArray[SwapLp, MAX_POOLS]: | |||
|
|
|||
| factory: IPoolFactory = IPoolFactory(factories[index]) | |||
|
|
|||
| if factory.address == self.v1_factory: | |||
| continue | |||
|
|
|||
| pools_count: uint256 = 0 | |||
stas
reviewed
Sep 26, 2023
| @@ -214,88 +197,11 @@ def _pools(with_convertor: bool) -> DynArray[address[3], MAX_POOLS]: | |||
|
|
|||
| return pools | |||
|
|
|||
| @external | |||
| @view | |||
| def toMigrate(_account: address) -> DynArray[Lp, MAX_POOLS]: | |||
There was a problem hiding this comment.
@ethzoomer this is still used by the dapp, I'm down to remove the migration, but will need it cleaned up from the app repo as well
There was a problem hiding this comment.
Will make app Linear task and start working on this
There was a problem hiding this comment.
Ty ty, this is good to merge otherwise.
stas
approved these changes
Sep 26, 2023
ethzoomer
added a commit
to aerodrome-finance/sugar
that referenced
this pull request
Apr 19, 2024
* Remove v1 pools from LpSugar * Remove all v1 calls from LpSugar * Point to latest LpSugar deployment * Add latest LpSugar address
ethzoomer
added a commit
to aerodrome-finance/sugar
that referenced
this pull request
Apr 19, 2024
* Remove v1 pools from LpSugar * Remove all v1 calls from LpSugar * Point to latest LpSugar deployment * Add latest LpSugar address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.